Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rules_apple #186

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Update rules_apple #186

merged 1 commit into from
Nov 5, 2020

Conversation

keith
Copy link
Member

@keith keith commented Nov 4, 2020

This is required for bazelbuild/bazel#12265

@google-cla google-cla bot added the cla: yes label Nov 4, 2020
@keith
Copy link
Member Author

keith commented Nov 4, 2020

Maybe we should switch this to use the git repo at HEAD though?

@keith keith mentioned this pull request Nov 4, 2020
Closed
@oquenchil oquenchil self-requested a review November 5, 2020 10:02
oquenchil
oquenchil approved these changes Nov 5, 2020
View reviewed changes
Copy link

@oquenchil oquenchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oquenchil oquenchil merged commit 990e28b into bazelbuild:master Nov 5, 2020
@keith keith deleted the ks/update-rules branch November 5, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oquenchil oquenchil oquenchil approved these changes

@brandjon brandjon Awaiting requested review from brandjon

@c-parsons c-parsons Awaiting requested review from c-parsons

@laurentlb laurentlb Awaiting requested review from laurentlb

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keith @oquenchil