Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel-genfiles do not exist since 1.0; fix the pipeline #810

Merged
merged 2 commits into from
Sep 5, 2019

Conversation

dslomov
Copy link
Contributor

@dslomov dslomov commented Sep 5, 2019

No description provided.

@dslomov dslomov requested a review from philwo September 5, 2019 12:21
@dslomov dslomov requested a review from fweikert as a code owner September 5, 2019 12:21
@dslomov
Copy link
Contributor Author

dslomov commented Sep 5, 2019

wdyt? (also what is a good way to try this?)

@philwo
Copy link
Member

philwo commented Sep 5, 2019

Oops :D

Laurent said that bazel-bin and bazel-genfiles have been equivalent (pointing to the same directory) for a few releases now, it's just that bazel-genfiles has been completely removed now.

So I think we can unconditionally use "bazel-bin" instead. WDYT?

@dslomov
Copy link
Contributor Author

dslomov commented Sep 5, 2019

Oops :D

Laurent said that bazel-bin and bazel-genfiles have been equivalent (pointing to the same directory) for a few releases now, it's just that bazel-genfiles has been completely removed now.

So I think we can unconditionally use "bazel-bin" instead. WDYT?

Awesomesauce, done

@philwo philwo merged commit 945e97b into master Sep 5, 2019
@philwo philwo deleted the dslomov-patch-1 branch September 5, 2019 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants