Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subtractive patterns in build_targets and test_targets. #245

Closed
wants to merge 1 commit into from

Conversation

mfarrugi
Copy link

@mfarrugi mfarrugi commented Mar 9, 2018

Wanted to skip some tests in bazelbuild/rules_rust#61, figured it was better to support negation than manually expand it.

(I have no idea if this breaks anything downstream of the actual bazel invocations, feel free to reject or lmk if there are other issues)

@philwo
Copy link
Member

philwo commented Mar 15, 2018

I think this is fine - @buchgr what do you think?

@buchgr
Copy link
Contributor

buchgr commented Mar 15, 2018

No, we have configs that specify "--" already and so these would break. We first need to fix these configs, but after that yes :-)

@buchgr buchgr self-assigned this Mar 15, 2018
@mfarrugi
Copy link
Author

This would require more coordination than it's worth to change.

@mfarrugi mfarrugi closed this Sep 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants