Throw a different Exception when failing to download Bazel at a given commit #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… commit Related bazelbuild/bazel#16933 (comment) - The "Publish Bazel binaries" pipeline sometimes fails to publish Bazel binaries for a commit, in this case, the Culprit Finder should immediately fail instead consider the commit as a bad Bazel commit. - Also removed some unused parameters in the function.
fweikert
approved these changes
Dec 8, 2022
fmeum
pushed a commit
to fmeum/continuous-integration
that referenced
this pull request
Dec 10, 2023
… commit (bazelbuild#1507) Related bazelbuild/bazel#16933 (comment) BuildKiteException is always caught at https://github.com/bazelbuild/continuous-integration/blob/4592271b2fdcf26f865d9c0082e1e53add7ea9a2/buildkite/bazelci.py#L3592-L3594 - The "Publish Bazel binaries" pipeline sometimes fails to publish Bazel binaries for a commit, in this case, the Culprit Finder should immediately fail instead consider the commit as a bad Bazel commit due to failing build. - Also removed some unused parameters in the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related bazelbuild/bazel#16933 (comment)
BuildKiteException is always caught at
continuous-integration/buildkite/bazelci.py
Lines 3592 to 3594 in 4592271
The "Publish Bazel binaries" pipeline sometimes fails to publish Bazel binaries for a commit, in this case, the Culprit Finder should immediately fail instead consider the commit as a bad Bazel commit due to failing build.
Also removed some unused parameters in the function.