Remove tensorflow Xcode version lock #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tensorflow was using Xcode 10.3 which is no longer supported for App Store uploads. This unpins the version since it should be compatible with any Xcode version.
|
Is there any way we can test this before merging? I can build tf locally with Xcode 12, but it would be nice to verify |
|
This was necessary due to tensorflow/tensorflow#32998, but it seems like later Xcode versions fixed the underlying issue. I can't think of an easy way to test this, as TensorFlow is not part of our normal pipelines for which we run presubmits. Let's just submit this and I'll kick off a build manually 👍 |
|
Thanks! That passed so we should be good here 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tensorflow was using Xcode 10.3 which is no longer supported for App
Store uploads. This unpins the version since it should be compatible
with any Xcode version.
This is required to unblock bazelbuild/bazel#12265