Add a warning for invalid string sequences #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentlb
approved these changes
Aug 8, 2019
warn/warn_operation.go
Outdated
| var problems []int // positions of the problems | ||
|
|
||
| escaped := false | ||
| // This for-loop doesn't correclty check for a backlash at the end of the string literal, but |
| } | ||
|
|
||
| switch ch { | ||
| case '\n', '\\', 'n', 'r', 't', 'x', '\'', '"', '0', '1', '2', '3', '4', '5', '6', '7': |
There was a problem hiding this comment.
Where does the list come from?
Can you include a link?
warn/warn_operation.go
Outdated
|
|
||
| var msg string | ||
| if len(problems) == 1 { | ||
| msg = fmt.Sprintf("Invalid quote sequences at position %d.", problems[0]) |
There was a problem hiding this comment.
Users might be confused by the message. Include at least the character that's incorrectly escaped.
Suggested:
Invalid quote sequence '\w' at position 18.
warn/warn_operation.go
Outdated
| } else { | ||
| msg = fmt.Sprintf( | ||
| "Invalid quote sequences at positions %s.", | ||
| strings.Trim(strings.Join(strings.Fields(fmt.Sprint(problems)), ", "), "[]"), |
There was a problem hiding this comment.
Suggested:
Invalid quote sequences:
'\w' at position 18
'\z' at position 23
or:
Invalid quote sequences '\w', '\z' at positions 18, 23
There was a problem hiding this comment.
Done (multiline warnings).
cristiancreteanu
pushed a commit
to cristiancreteanu/buildtools
that referenced
this pull request
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #688.