Add native-proto fix to buildifier #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a fix for the native-to-starlark migration of Protobuf rules. Also, the implementation is refactored to add support for warnings when symbols should be loaded.
|
/cc @lberki I'm not fully qualified to review this, so I'll let the others shine, but I'm happy that this is happening! |
|
@vladmos Can we get this in before Bazel 0.29.0 is released? bazelbuild/bazel#8922 |
cristiancreteanu
pushed a commit
to cristiancreteanu/buildtools
that referenced
this pull request
Aug 30, 2019
This change adds a fix for the native-to-starlark migration of Protobuf rules. Also, the implementation is refactored to add support for warnings when symbols should be loaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a fix for the native-to-starlark migration of Protobuf
rules. Also, the implementation is refactored to add support for warnings
when symbols should be loaded.
/cc @hlopko @lberki @iirina