Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate use of deprecated distutils.version module #379

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

jbms
Copy link
Contributor

@jbms jbms commented Sep 24, 2022

Since the recommended replacement, packaging.version, is not in the standard library, this commit instead just implements a simple version number comparison without any additional dependencies.

@jbms jbms force-pushed the fix-distutils-version-deprecation branch from 6800ee7 to b696141 Compare September 25, 2022 19:07
copybara-service bot pushed a commit to google/tensorstore that referenced this pull request Oct 3, 2022
Eliminate `template_rule` from `utils.bzl`.  This is now available as
`expand_template` from bazel_skylib.

Eliminate `cc_library_with_strip_include_prefix` from `utils.bzl`.
The Bazel bug (bazelbuild/bazel#6337) is
fixed as of Bazel 5.0.

Replace uses of `genrule` with `write_file` from bazel_skylib.

Eliminate unnecssary `constraint_value` -> `config_setting` aliases,
now that Bazel allows constraint_value targets to be used directly in
`select`.

Updates bazelisk.py to fix deprecation warning:
bazelbuild/bazelisk#379

PiperOrigin-RevId: 478621631
Change-Id: I2e647861a78ee456fd44bc6f23223611162a136f
bazelisk.py Outdated Show resolved Hide resolved
@fweikert fweikert self-requested a review November 4, 2022 13:03
Since the recommended replacement, `packaging.version`, is not in the
standard library, this commit instead just implements a simple version
number comparison without any additional dependencies.
@jbms jbms force-pushed the fix-distutils-version-deprecation branch from b696141 to 7fa1796 Compare November 4, 2022 16:40
@fweikert
Copy link
Member

fweikert commented Nov 4, 2022

Thank you!

@fweikert fweikert merged commit ff34a81 into bazelbuild:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants