Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chocolatey Package] Could we add bazelisk to PATH as bazel? #311

Closed
cpsauer opened this issue Mar 30, 2022 · 6 comments · Fixed by #312
Closed

[Chocolatey Package] Could we add bazelisk to PATH as bazel? #311

cpsauer opened this issue Mar 30, 2022 · 6 comments · Fixed by #312

Comments

@cpsauer
Copy link
Contributor

cpsauer commented Mar 30, 2022

@digitalcoyote, I super appreciate your Chocolatey package for Bazelisk--as someone now booting up on Windows after working with Bazel on macOS and Linux.

Could I ask you if, by any chance, you'd be willing to have the package (additionally) add Bazelisk to the PATH as bazel? That's a super handy feature on other platforms that makes it easy to use as a drop-in replacement.

Thanks so much for your consideration and all you've done.
Chris
@cpsauer
Copy link
Contributor Author

cpsauer commented Mar 30, 2022 •
edited
Loading

(That is, during install cmd: mklink C:\ProgramData\chocolatey\bin\bazel.exe C:\ProgramData\chocolatey\bin\bazelisk.exe)

digitalcoyote added a commit to digitalcoyote/chocolatey-packages that referenced this issue Mar 30, 2022
@digitalcoyote
Add bazelisk to path as Bazel
2b12ed5 
Per bazelbuild/bazelisk#311 adding bazel to path Using a symlink of Bazelisk. 

Probably needs to either force itself if the link already exists.
@digitalcoyote digitalcoyote mentioned this issue Mar 30, 2022
Merged
@cpsauer
Copy link
Contributor Author

cpsauer commented Mar 31, 2022

Thanks so much for working on this, Curtis! Will definitely make things extra awesome. Sorry if I should have filed it over in digitalcoyote/chocolatey-packages

No pressure to respond, but this Windows newbie is curious what went into choosing a hard link (vs soft). (I know things are different over in windows-land.)

@digitalcoyote
Copy link

Honestly, I just default to hard links anytime I'm on the same drive ever since I read an article about some Windows utilities having issues following soft links.

@macellan401
Copy link

macellan401 commented Mar 31, 2022 via email

digitalcoyote added a commit to digitalcoyote/chocolatey-packages that referenced this issue Mar 31, 2022
@digitalcoyote
Add bazelisk to path as Bazel
46d85bc 
Per bazelbuild/bazelisk#311 adding bazel to path Using a symlink of Bazelisk. 

Probably needs to either force itself if the link already exists.
@digitalcoyote
Copy link

Pushed a fix version to chocolatey (has today's date appended to the bazelisk version) that should include bazel on the path.

@cpsauer
Copy link
Contributor Author

cpsauer commented Mar 31, 2022

Thank you again!
From https://community.chocolatey.org/packages/bazelisk, it looks like it's already available! (That is the review process, right?)

Before closing, I'll toss up a quick PR to document the choco support so more people can use and find it!

@cpsauer cpsauer mentioned this issue Mar 31, 2022
Merged
fweikert pushed a commit that referenced this issue Apr 4, 2022
@cpsauer
Add Windows chocolatey support to README.md (#312)
bef772c 
Also notes new parallel PATH behavior, wherein bazelisk is also added as bazel.
Thanks @digitalcoyote!
Fixes #311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Windows chocolatey support to README.md
3 participants
@cpsauer @digitalcoyote @macellan401