Java stub perf improvements #9314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iirina
approved these changes
Sep 3, 2019
gnarled-cipher
pushed a commit
to gnarled-cipher/bazel
that referenced
this pull request
Sep 4, 2019
When the `classpath` is too long the stub writes it to a manifest file At Wix it is not unusual to find tests targets with a very long `classpath`. For a test target with 1.1MB long `classpath` and with over 2600 entries it takes over 55 seconds to construct and write the manifest file with the current stub. With the suggested fix it takes ~20 millis to construct manifest file for the same target Closes bazelbuild#9314. PiperOrigin-RevId: 266905451
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
classpathis too long the stub writes it to a manifest fileAt Wix it is not unusual to find tests targets with a very long
classpath. For a test target with 1.1MB longclasspathand with over 2600 entries it takes over 55 seconds to construct and write the manifest file with the current stub.With the suggested fix it takes ~20 millis to construct manifest file for the same target