Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags propagation for java rules #9274

Closed
wants to merge 2 commits into from

Conversation

ishikhman
Copy link
Contributor

Part of #8830

RELNOTES[NEW]: tags: use --experimental_allow_tags_propagation flag to propagate tags to the action's execution requirements from java targets. Such tags should start with: no-, requires-, supports-, block-, disable-, cpu:. See #8830 for details.

@ishikhman ishikhman force-pushed the tags-java branch 3 times, most recently from 11a98c8 to 1cb34ca Compare August 29, 2019 09:43
@ishikhman ishikhman marked this pull request as ready for review August 29, 2019 09:43
@ishikhman ishikhman requested a review from hlopko as a code owner August 29, 2019 09:43
@ishikhman ishikhman requested a review from buchgr August 29, 2019 09:44
@ishikhman
Copy link
Contributor Author

@buchgr @hlopko This one is heavily based on #9267 , so look at the latest commit for specific changes: 1cb34ca

@iirina iirina added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Aug 29, 2019
@ishikhman ishikhman force-pushed the tags-java branch 3 times, most recently from e585ef8 to 5224a88 Compare August 30, 2019 12:12
@dslomov
Copy link
Contributor

dslomov commented Sep 2, 2019

Is this still a 1.0 blocker?

@bazel-io bazel-io closed this in 58d3f17 Sep 2, 2019
@ishikhman
Copy link
Contributor Author

@dslomov well, it merged, so not anymore

@buchgr
Copy link
Contributor

buchgr commented Sep 2, 2019

yay! congrats!

@ishikhman ishikhman mentioned this pull request Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants