Client: convert output_base to Path #9245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laszlocsomor
changed the title
Benefits of a Path abstraction instead of raw strings: - type safety - no need to convert paths on Windows all the time - no need to check if paths are absolute Change-Id: I33438503e692c27a31975b5e496da11ebfe300f3
|
ping @meteorcloudy |
meteorcloudy
approved these changes
Aug 27, 2019
bazel-io
pushed a commit
that referenced
this pull request
Aug 27, 2019
*** Reason for rollback *** TAP has detected 10 or more targets failed to build at 242acd6. TO ROLLFORWARD (without additional approval): Use[] To see all broken targets visit [] To prevent noise from flakes, TAP double-checked the following target fails to build: [] but used to build fine: [] Questions? Comments? See the URL:[] *** Original change description *** Client: convert output_base to Path Benefits of a Path abstraction instead of raw strings: - type safety - no need to convert paths on Windows all the time - no need to check if paths are absolute Closes #9245. Change-Id: I33438503e692c27a31975b5e496da11ebfe300f3 PiperOrigin-RevId: 265667040
bazel-io
pushed a commit
that referenced
this pull request
Aug 27, 2019
(Roll-forward of commit 242acd6 that was rolled back by commit 505ca7e because it broke Google-internal build targets. Those are now fixed.) Benefits of a Path abstraction instead of raw strings: - type safety - no need to convert paths on Windows all the time - no need to check if paths are absolute Closes #9245. RELNOTES: none PiperOrigin-RevId: 265686214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benefits of a Path abstraction instead of raw
strings: