[protobuf] Load C++,Java,Protobuf rules from Starlark #9001
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #9002 |
Yannic
force-pushed
the
merge_proto_6432_and_6445
branch
2 times, most recently
from
4aff07a to
7dc5c8f
Compare
Yannic
force-pushed
the
merge_proto_6432_and_6445
branch
from
7dc5c8f to
137cc78
Compare
Yannic
commented
Aug 6, 2019
| @@ -24,9 +27,6 @@ config_setting( | |||
| load(":protobuf.bzl", "py_proto_library") | |||
| load(":compiler_config_setting.bzl", "create_compiler_config_setting") | |||
|
|
|||
| # Needed for #9006. Hopefully a future upstream version will include this line. | |||
There was a problem hiding this comment.
I sent a PR to Protobuf to fix this, so I don't think this comment is needed.
|
Merged as deeeba3 so I'm closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of: protocolbuffers/protobuf#6432 and protocolbuffers/protobuf#6445