-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[protobuf] Load C++,Java,Protobuf rules from Starlark #9001
Conversation
Depends on #9002 |
4aff07a
to
7dc5c8f
Compare
7dc5c8f
to
137cc78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lberki This change is ready for review. ptal.
@@ -24,9 +27,6 @@ config_setting( | |||
load(":protobuf.bzl", "py_proto_library") | |||
load(":compiler_config_setting.bzl", "create_compiler_config_setting") | |||
|
|||
# Needed for #9006. Hopefully a future upstream version will include this line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sent a PR to Protobuf to fix this, so I don't think this comment is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. You're awesome :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me merge this!
Merged as deeeba3 so I'm closing this. |
Cherry-pick of: protocolbuffers/protobuf#6432 and protocolbuffers/protobuf#6445