Restrict string escape sequences and introduce flag #8526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quarz0
requested review from
brandjon,
c-parsons,
dkelmer,
dslomov,
laurentlb,
tualeron and
vladmos
as code owners
Quarz0
force-pushed
the
string_escapes
branch
2 times, most recently
from
06e01e3
to
c572544
Compare
laurentlb
reviewed
May 31, 2019
When the flag is enabled, invalid escape sequences like "\z" are rejected. RELNOTES: Flag `--incompatible_restrict_escape_sequences` is added. See bazelbuild#8380
vladmos
approved these changes
Jun 4, 2019
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jun 18, 2019
Related: bazelbuild#8380 , [bazelbuild#38](bazelbuild/starlark#38) introduce flag --incompatible_restrict_escape_sequences=false When the flag is enabled, invalid escape sequences like "\z" are rejected. RELNOTES: Flag `--incompatible_restrict_escape_sequences` is added. See bazelbuild#8380 Closes bazelbuild#8526. PiperOrigin-RevId: 251434634
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jul 15, 2019
Related: bazelbuild#8380 , [bazelbuild#38](bazelbuild/starlark#38) introduce flag --incompatible_restrict_escape_sequences=false When the flag is enabled, invalid escape sequences like "\z" are rejected. RELNOTES: Flag `--incompatible_restrict_escape_sequences` is added. See bazelbuild#8380 Closes bazelbuild#8526. PiperOrigin-RevId: 251434634
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #8380 , #38
introduce flag --incompatible_restrict_escape_sequences=false
When the flag is enabled, invalid escape sequences like "\z" are
rejected.
RELNOTES: Flag
--incompatible_restrict_escape_sequencesis added. See#8380