Only add CoverageOutputGenerator in coverage mode. #8477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlopko
suggested changes
May 28, 2019
There was a problem hiding this comment.
Thanks for finding time to work on this so quickly! Only single clasification needed. Thank you!
Would you mind adding 2 tests (unless one of them exists already):
- one in BuildViewTestCase that tests that sh_tests implicit dependency label is null
- one in CoverageCommandTest that tests that sh_test in coverage has implicit dependency on the right label. I'm not sure if we have this test in bazel, if we don't and you don't know how to proceed, I'll be fine with having an integration test that will cover this branch.
Thanks you!
src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java
Outdated
Show resolved
Hide resolved
Rename to :lcov_merger according to the late-bound attributes naming policy.
|
I added the tests in a new |
hlopko
approved these changes
May 28, 2019
src/test/java/com/google/devtools/build/lib/rules/sh/BazelShTestConfiguredTargetTest.java
Outdated
Show resolved
Hide resolved
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jun 18, 2019
Fixes bazelbuild#8355. Closes bazelbuild#8477. PiperOrigin-RevId: 250489150
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jul 15, 2019
Fixes bazelbuild#8355. Closes bazelbuild#8477. PiperOrigin-RevId: 250489150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8355.