Allow Starlark rules to be able to use the exec_compatible_with
#8453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attribute by default. Fixes bazelbuild#8451, part of bazelbuild#8134.
laurentlb
approved these changes
May 24, 2019
|
The specific issue is because in the original version, all test rules had exec_compatible_with_allowed set to True by default, and when I started changing the default that was dropped. Once the migration is complete, all rules will have it set (in fact, it will be removed and assumed true). There are existing tests for starlark rules, just not for starlark test rules. Given the future direction will make no special provisions for starlark test rules, does a separate test make sense? |
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jun 18, 2019
attribute by default. Fixes bazelbuild#8451, part of bazelbuild#8134. Closes bazelbuild#8453. PiperOrigin-RevId: 249804440
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jul 15, 2019
attribute by default. Fixes bazelbuild#8451, part of bazelbuild#8134. Closes bazelbuild#8453. PiperOrigin-RevId: 249804440
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attribute by default.
Fixes #8451, part of #8134.