Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit execution and target constraints for autodiscovered cc t… #8332

Closed
wants to merge 2 commits into from
Closed

Add explicit execution and target constraints for autodiscovered cc t… #8332

wants to merge 2 commits into from

Conversation

katre
Copy link
Member

@katre katre commented May 15, 2019

…oolchains.

Fixes #8330.

@katre katre force-pushed the i8330-constraints-for-auto-cc-toolchains branch from 1464878 to 0eedd23 Compare May 15, 2019 15:19
@katre katre marked this pull request as ready for review May 15, 2019 16:24
@katre katre requested review from hlopko and sergiocampama May 15, 2019 16:24
hlopko
hlopko approved these changes May 15, 2019
View reviewed changes
Copy link
Member

@hlopko hlopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, to double check, this should not affect people who didn't flip --incompatible_enable_cc_toolchain_resolution, and those that did flip the flag should get the more correct behavior which we wouldn't consider a breaking change, would you agree? :)

@katre
Copy link
Member Author

katre commented May 15, 2019

Yes, that is correct.

@bazel-io bazel-io closed this in 7dc78cd May 15, 2019
aehlig pushed a commit that referenced this pull request May 17, 2019
@katre @aehlig
Add explicit execution and target constraints for autodiscovered cc t?
7b74053 
?oolchains.

Fixes #8330.

Closes #8332.

PiperOrigin-RevId: 248383561
aehlig pushed a commit that referenced this pull request May 20, 2019
@katre @aehlig
Add explicit execution and target constraints for autodiscovered cc t?
b9e44cb 
?oolchains.

Fixes #8330.

Closes #8332.

PiperOrigin-RevId: 248383561
aehlig pushed a commit that referenced this pull request May 21, 2019
@katre @aehlig
Add explicit execution and target constraints for autodiscovered cc t?
1fad672 
?oolchains.

Fixes #8330.

Closes #8332.

PiperOrigin-RevId: 248383561
aehlig pushed a commit that referenced this pull request May 22, 2019
@katre @aehlig
Add explicit execution and target constraints for autodiscovered cc t?
57a34ad 
?oolchains.

Fixes #8330.

Closes #8332.

PiperOrigin-RevId: 248383561
aehlig pushed a commit that referenced this pull request May 23, 2019
@katre @aehlig
Add explicit execution and target constraints for autodiscovered cc t?
cbdedb0 
?oolchains.

Fixes #8330.

Closes #8332.

PiperOrigin-RevId: 248383561
aehlig pushed a commit that referenced this pull request May 23, 2019
@katre @aehlig
Add explicit execution and target constraints for autodiscovered cc t?
1641492 
?oolchains.

Fixes #8330.

Closes #8332.

PiperOrigin-RevId: 248383561
aehlig pushed a commit that referenced this pull request May 24, 2019
@katre @aehlig
Add explicit execution and target constraints for autodiscovered cc t?
58dd59a 
?oolchains.

Fixes #8330.

Closes #8332.

PiperOrigin-RevId: 248383561
irengrig pushed a commit to irengrig/bazel that referenced this pull request Jun 18, 2019
@katre @irengrig
Add explicit execution and target constraints for autodiscovered cc t?
36fbe74 
?oolchains.

Fixes bazelbuild#8330.

Closes bazelbuild#8332.

PiperOrigin-RevId: 248383561
@katre katre deleted the i8330-constraints-for-auto-cc-toolchains branch August 2, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlopko hlopko hlopko approved these changes

@sergiocampama sergiocampama Awaiting requested review from sergiocampama

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong cc toolchain selected on Mac
3 participants
@katre @hlopko @googlebot