correctly access javabase in java_integration_test #8047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
java_integration_test assumes that $(JAVABASE) is always a runfiles relative path. However, that's not correct as it purely depends on the usage of java_runtime. For example, java_runtime( name = "abs_path_jdk", java_home = "/usr/local/lib/jdk", ) when running with --javabase=//:abs_path_jdk then all $(JAVABASE) make variables will contain "/usr/local/lib/jdk". Progress towards bazelbuild#8033
laszlocsomor
suggested changes
Apr 15, 2019
laszlocsomor
suggested changes
Apr 16, 2019
laszlocsomor
approved these changes
Apr 16, 2019
|
What's the current status of this PR? |
|
The PR is not yet merged. |
|
This fails in CI. All of them. "line 48: CURRENT_DIR: unbound variable" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java_integration_test assumes that $(JAVABASE) is always a runfiles
relative path. However, that's not correct as it purely depends on
the usage of java_runtime.
For example,
java_runtime(
name = "abs_path_jdk",
java_home = "/usr/local/lib/jdk",
)
when running with --javabase=//:abs_path_jdk then all $(JAVABASE)
make variables will contain "/usr/local/lib/jdk".
Progress towards #8033