fix zip64_test to work with absolute $(JAVABASE) #8034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with an absolute $(JAVABASE) and --(no)legacy_external_runfiles. Progress towards bazelbuild#8033
laszlocsomor
suggested changes
Apr 15, 2019
src/tools/singlejar/zip64_test.sh
Outdated
| @@ -53,7 +53,15 @@ else | |||
| fi | |||
|
|
|||
| singlejar="$(rlocation "io_bazel/src/tools/singlejar/singlejar${EXE_EXT}")" | |||
| jartool="$(rlocation "local_jdk/bin/jar${EXE_EXT}")" | |||
| javabase="$1" | |||
| if [[ $javabase = /* ]]; then | |||
There was a problem hiding this comment.
Code assumes $1 is Unix-style path. What about Windows paths?
There was a problem hiding this comment.
I am happy to add a code snippet for Windows to this change if you tell me what I should add :-). I don't think it's a necessary part of this PR though.
There was a problem hiding this comment.
if [[ $javabase = /* || $javabase =~ [A-Za-z]:[/\\] ]]; then
laszlocsomor
approved these changes
Apr 15, 2019
buchgr
added a commit
to buchgr/bazel
that referenced
this pull request
Apr 15, 2019
Tested with an absolute $(JAVABASE) and --(no)legacy_external_runfiles. Progress towards bazelbuild#8033 Closes bazelbuild#8034. PiperOrigin-RevId: 243604034
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with an absolute $(JAVABASE) and --(no)legacy_external_runfiles.
Progress towards #8033