Split android common into two. #7971
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisterT
force-pushed
the
split_android_common
branch
from
0ff514d to
f6ac940
Compare
This helps to remove 3MB from Bazel's binary size immediately but also will get us much closer to remove the dependency on the java.desktop module. It will also allow us to remove the jdk.compiler module. Commit 1/2 RELNOTES: None
meisterT
force-pushed
the
split_android_common
branch
from
f6ac940 to
decb551
Compare
philwo
approved these changes
Apr 12, 2019
bazel-io
pushed a commit
that referenced
this pull request
Apr 12, 2019
This helps to remove 3MB from Bazel's binary size immediately but also will get us much closer to remove the dependency on the java.desktop module. It will also allow us to remove the jdk.compiler module. Commit 1/2 RELNOTES: None Partial commit for third_party/*, see #7971. Signed-off-by: Philipp Wollermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps to remove 3MB from Bazel's binary size immediately but also
will get us much closer to remove the dependency on the java.desktop
module.
It also allows us to remove the jdk.compiler module.
RELNOTES: None