Wrap StatusRuntimeExceptions from GrpcRemoteCache #7860
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exceptions that occur during remote interactions are expected to be
wrapped in IOException for observation by the RemoteSpawn{Runner,Cache}
layers.
Fixes bazelbuild#7856
buchgr
reviewed
Mar 28, 2019
| retrier.executeAsync( | ||
| () -> ctx.call( | ||
| () -> requestRead(resourceName, offset, progressiveBackoff, digest, out, hashSupplier)), | ||
| progressiveBackoff), |
There was a problem hiding this comment.
The previous implementation of the progressive read did not use the progressive backoff to determine the retry delay of successive requests. Put simply, we got progressive reads due to the offset, but there was no meaning to the progress from the perspective of the backoff used to proceed. A single download got max_retry_attempts to complete the download, and that's it - without this there was no effect to the progressiveBackoff being introduced.
werkt
pushed a commit
to werkt/bazel
that referenced
this pull request
Mar 29, 2019
Exceptions that occur during remote interactions are expected to be
wrapped in IOException for observation by the RemoteSpawn{Runner,Cache}
layers.
Fixes bazelbuild#7856
Closes bazelbuild#7860.
PiperOrigin-RevId: 240793745
werkt
pushed a commit
to werkt/bazel
that referenced
this pull request
Jan 27, 2020
Consistent with bazelbuild#7860, present an IOException with context to ensure fallback if configured, rather than an unhandled RuntimeException and bazel crash, when issuing FindMissingBlobs requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions that occur during remote interactions are expected to be
wrapped in IOException for observation by the RemoteSpawn{Runner,Cache}
layers.
Fixes #7856