Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh roots prototype #7752

Closed
wants to merge 29 commits into from
Closed

refresh roots prototype #7752

wants to merge 29 commits into from

Conversation

irengrig
Copy link
Contributor

No description provided.

Quarz0 and others added 13 commits March 18, 2019 11:44
**Related issues:**
- add -c flag [#35](bazelbuild/starlark#35)
- improve starlark-in-java installation documentation [#24](bazelbuild/starlark#24)

**Examples:**
$ bazel run :Starlark -- -c "print(1)"
1
$ bazel run :Starlark -- -c "print(1)" arg3
USAGE: Starlark [-c "\<cmdLineProgram\>" | \<fileName\>]

Closes #7683.

PiperOrigin-RevId: 239028987
Make the fake implementation of repository_rule register the rule
instead of blindly returning the implementation function. In this
way, the documentation generated for repository rules contains the
correct arguments.

Fixes bazelbuild/skydoc#168

Change-Id: I4b4101a9a604282051eeaadafccdc9a987b14264
PiperOrigin-RevId: 239029265
PiperOrigin-RevId: 239035315
Introduces a new SkyFunction which reads a platform mapping file, parses its contents and produces a platform mapping sky value which can then be used to apply the mapping to configurations (in the form of BuildConfigurationValue.Key).

The file's location is obtained from the newly introduced flag --platform_mappings and defaults to //:platform_mappings.

Note that this logic is not in use anywhere yet because the key mapping has not been applied. This will follow in a future CL.

Step 4/N towards the platforms mapping functionality for #6426

RELNOTES: None.
PiperOrigin-RevId: 239043475
Issue #5380
RELNOTES: None.
PiperOrigin-RevId: 239053687
We expect rules to map all the input files they need, including the targets
of those symlinks.  Unfortunately, not all rules currently abide by this
principle, which means that using the stricter sandboxfs sandboxing causes
these rules to fail.

In order to mitigate this problem and to have an escape hatch for using
sandboxfs in the presence of these bugs, compute what the targets of the
symlinks are and map them automatically within the sandbox unless they were
explicitly mapped.

But because we treat this condition as a bug in the rules (and because
doing this computation is not trivial), this behavior is optional and is
disabled by default.  Users encountering this problem in the rules they use
(or in their own rules) can temporarily enable the looser sandboxing by
setting --experimental_sandboxfs_map_symlink_targets.

RELNOTES: None.
PiperOrigin-RevId: 239066555
… classes where possible.

PiperOrigin-RevId: 239100491
This is in preparation of updating the Mockito version internally.

Change-Id: I82c3471fbf7a31731958d9c626b0de22690c9c07
Partial commit of third_party/*. See #7708.

Signed-off-by: iirina <[email protected]>
Use the zip format instead of tar.gz for the Java tools releases on all platforms, not only on Windows.

Closes #7760.

PiperOrigin-RevId: 239153828
…refresh-roots-for-squash2

# Conflicts:
#	src/main/java/com/google/devtools/build/lib/skyframe/IgnoredAndRefreshedConfigurationHelper.java
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

irengrig and others added 12 commits March 19, 2019 11:46
f5c3342 changed the hash of the
 file java_tools_javac10_windows-x86_64-v1.0.zip leading to multiple projects that were using an old commit to the Bazel repo to fail. This commit uses an intermediate name for the file in order to allow restoring the previous file with the previous hash on GCS.

RELNOTES: None.
PiperOrigin-RevId: 239164275
Issue #5380
RELNOTES: None.
PiperOrigin-RevId: 239168544
…refresh-roots-for-squash2

# Conflicts:
#	src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java
- similar to loading_phase_test.sh test_no_package_loading_on_benign_workspace_file_changes
…hing changed

- similar to bazel_workspace_test.sh text_execute()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants