-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend dict update to accept keyword args #7684
Conversation
Thanks for the pull request! @brandjon, can you look at this PR? Both Chris and I are on leave this week. |
I added some tests |
Roger, will review later today. |
src/main/java/com/google/devtools/build/lib/syntax/SkylarkDict.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks
If there's no more issue, I'm going to import this change.
Approved, though I suggested one additional assertion for the unit test for Laurent to add as we're importing. |
fyi, I added a few more tests here: 4d65f44 |
Closes dict.update should return None, not self #18
dict.update() method should now accept keyword args just like dict(...)
Example of usage: