Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for a Spawn to declare a required local output #7271

Closed
wants to merge 1 commit into from

Conversation

buchgr
Copy link
Contributor

@buchgr buchgr commented Jan 28, 2019

Some native actions run both remotely and locally. For example,
the CppCompileAction runs compilation remotely but does .d file
pruning locally. This change adds the necessary infrastructure
for an action to tell a Spawn which of its outputs it needs on
the local filesytem.

Progress towards #6862

@buchgr buchgr changed the title add ability to stage local outputs Add ability for a Spawn to declare a required local output Jan 28, 2019
Copy link
Member

@hlopko hlopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from styleguide nits that I'll keep to myself LGTM :)

@jin jin added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Feb 19, 2019
Some native actions run both remotely and locally. For example,
the CppCompileAction runs compilation remotely but does .d file
pruning locally. This change adds the necessary infrastructure
for an action to tell a Spawn which of its outputs it needs on
the local filesytem.

Progress towards bazelbuild#6862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants