Rename SymlinkEvent.to to SymlinkEvent.path and SymlinkEvent.from to SymlinkEvent.target. #6885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminp
force-pushed
the
symlink-names
branch
2 times, most recently
from
f4513d4 to
8e9133a
Compare
…SymlinkEvent.target.
This naming has the advantages of
1. Being more consistent with traditional symlink terminology (c.f. `man ln`), other workspace log events ("path" is used for the filesystem entry that is created in the other event messages), and Bazel Starlark APIs ("SymlinkEntry" uses "path" and "target_file").
2. Avoids field names that are likely to be language keywords. In particular, "from" and "to" are both keywords in Python.
I assume the compatibility breakage here is okay because the workspace log is all under --experimental_workspace_rules_log_file.
jin
added
the
team-ExternalDeps
|
Looks good to me. |
agoulti
approved these changes
Dec 18, 2018
philwo
added
the
team-OSS
philwo
removed
the
team-OSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This naming has the advantages of
man ln), other workspace log events ("path" is used for the filesystem entry that is created in the other event messages), and Bazel Starlark APIs ("SymlinkEntry" uses "path" and "target_file").I assume the compatibility breakage here is okay because the workspace log is all under --experimental_workspace_rules_log_file.
This fixes #6887.