C++ compilation: flag for header-validation debug #6866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the --[no]experimental_header_validation_debug flag. This flag tells Bazel to print extra debugging information when a C++ compilation action fails header inclusion validation. We will enable this flag on BuildKite in hopes of catching the culprit of bazelbuild#6847. After we find the culprit, this commit should be reverted and the --experimental_header_validation_debug flag from BuildKite's configuration should be removed. See bazelbuild#6847
|
In light of my recent theory of what causes the bug (#6847 (comment)), this PR is now pointless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the --[no]experimental_header_validation_debug
flag.
This flag tells Bazel to print extra debugging
information when a C++ compilation action fails
header inclusion validation.
We will enable this flag on BuildKite in hopes of
catching the culprit of #6847.
After we find the culprit, this commit should be
reverted and the
--experimental_header_validation_debug flag from
BuildKite's configuration should be removed.
See #6847