Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable --incompatible_disable_sysroot_from_configuration by default. #6614

Closed
wants to merge 2 commits into from
Closed

Enable --incompatible_disable_sysroot_from_configuration by default. #6614

wants to merge 2 commits into from

Conversation

katre
Copy link
Member

@katre katre commented Nov 6, 2018

Incompatible change issue: #6565.
Part of overall sysroot cleanup in #6543.

RELNOTES: Turn on --incompatible_disable_sysroot_from_configuration

katre added 2 commits November 6, 2018 11:15
@katre
Enable the flag --incompatible_disable_sysroot_from_configuration by
b746386 
default.

Incompatible change issue: #6565.
part of overall sysroot cleanup in #6543.
@katre
Fix tests
edb59c1
@katre
Copy link
Member Author

katre commented Nov 6, 2018

Ran tests on downstream projects: https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/564
Failures are also in latest postsubmit from HEAD, and so are not due to this change.

@bazel-io bazel-io closed this in efc4338 Nov 8, 2018
@philwo philwo deleted the katre-i6543-flip-flag-default branch January 14, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scentini scentini scentini approved these changes

@lberki lberki Awaiting requested review from lberki lberki is a code owner

@hlopko hlopko Awaiting requested review from hlopko

@oquenchil oquenchil Awaiting requested review from oquenchil

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katre @scentini @googlebot