Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Make Python binary work with runfiles symlink tree #6036

Closed
wants to merge 2 commits into from
Closed

Windows: Make Python binary work with runfiles symlink tree #6036

wants to merge 2 commits into from

Conversation

meteorcloudy
Copy link
Member

No description provided.

@meteorcloudy meteorcloudy requested a review from lberki as a code owner August 30, 2018 14:49
@jin jin added the area-Windows Windows-specific issues and feature requests label Aug 30, 2018
@laszlocsomor
Copy link
Contributor

Could you take a look at the failing tests?

@meteorcloudy
Windows: Make Python binary work with runfiles symlink tree
e098094 
Change-Id: Ibdd03de616e727286eb2a53ca5b08d46e76b2b1c
@meteorcloudy
Copy link
Member Author

Failing tests have been fixed, PTAL~

laszlocsomor
laszlocsomor reviewed Sep 3, 2018
View reviewed changes
src/test/shell/bazel/bazel_windows_example_test.sh Outdated
bazel build -s --verbose_failures $BUILD_FLAGS //examples/py_native:bin \
|| fail "Failed to build //examples/py_native:bin with runfiles support"
(
# Clear runfiles related envs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To help readability, please indent the lines running in a subshell (line 204 .. 215).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

src/test/shell/integration/runfiles_test.sh Show resolved Hide resolved
@meteorcloudy
Add indentation
16ab654 
Change-Id: I1f8ffc6cf675c86b4799682282398dd847babcf0
@lberki
Copy link
Contributor

lberki commented Sep 3, 2018

/cc @brandjon

@bazel-io bazel-io closed this in fb164a0 Sep 3, 2018
@FuegoFro FuegoFro mentioned this pull request Jan 11, 2019
Open
@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laszlocsomor laszlocsomor laszlocsomor approved these changes

@lberki lberki Awaiting requested review from lberki lberki is a code owner

Assignees
No one assigned
Labels
area-Windows Windows-specific issues and feature requests cla: yes team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@meteorcloudy @laszlocsomor @lberki @jin @philwo @googlebot