Use @loader_path instead of $ORIGIN in rpath on macos. Issue #4480.

[alexanderlobov]

This patch fixes the issue with $ORIGIN in rpath on macos #4480. I'm not sure whether it is the best way to solve the issue, but it works :) I have a superficial knowledge about bazel's code, so feel free to correct me if I'm wrong in some way.

There a still several open questions:

1. I'm not use should we use @loader_path or @executable_path. As I understand, it is the same for plain executables, and only makes a difference for mac's frameworks or 'app' directories. But description in man dyld is pretty crypric to me.

2. There is a file tools/osx/crosstool/CROSSTOOL.tpl, that conains "-Wl,-rpath,$ORIGIN/%{runtime_library_search_directories}". I have tried to change it too, but it have not affected my test project. I'm not sure should I change this file too.

3. I tested as described here. If there is another way, say me.

   bazel build //:bazel-distfile
   #unzip to a tmp directory
   bazel test //src/... //third_party/ijar/...
   

I tested using this project.

[bazel-io]

Can one of the admins verify this patch?

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
• If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
• In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

[alexanderlobov]

I have created a new pull request with my corporate email address in the commit, #4589
I'm closing this pull request.