-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Bazel itself build under an output base with Unicode characters #24457
base: master
Are you sure you want to change the base?
Conversation
924c57a
to
3d80129
Compare
3d80129
to
abc6d14
Compare
I suspect that the RBE failure is due to the remote execution environment not having the |
I think that entails creating a new docker image for RBE (or finding a suitable existing one). @coeuvre, do you know how to do this? If this is blocking for 8.0.0, I suggest finding a way to either detect the existence of the locale in the test, or disable it when on RBE. |
The test is failing on other platforms, so I'll look into that. It's not a hard blocker for 8.0.0, it can equally well go into 8.1.0. |
This needs a fix in rules_java to properly set a UTF-8 environment for bootstrap actions: bazelbuild/rules_java#243 |
Copybara Import from #243 BEGIN_PUBLIC Build bootclasspath in a UTF-8 environment (#243) `java` and `javac` convert file and classpaths to absolute paths and thus require a UTF-8 locale to work under a path that contains non-ASCII characters. Unblocks bazelbuild/bazel#24457 Closes #243 END_PUBLIC COPYBARA_INTEGRATE_REVIEW=#243 from fmeum:utf8-environment 05813e4 PiperOrigin-RevId: 700695134 Change-Id: I2f5753720ec3c838a4dd8b6aabf1050c6935ef3d
Path#getInputStream()
, thus avoiding string encoding issues when constructing aFileInputStream
manually.Path#createTempDirectory
function is introduced to replace error-prone usages ofFiles.createTempDirectory
throughout the code base, which requires reencoding of both the arguments and the return value.argv0
inSubprocessBuilder
andWorkerMultiplexer
.info
output.Work towards #374
Fixes #24444