Move C++ runfiles library out of Bazel #24393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-ExternalDeps
fmeum
force-pushed
the
drop-cc-runfiles-library
branch
from
daff6cb to
8d484b9
Compare
fmeum
force-pushed
the
drop-cc-runfiles-library
branch
from
8d484b9 to
ae99848
Compare
fmeum
force-pushed
the
drop-cc-runfiles-library
branch
2 times, most recently
from
f6f650a to
a43b78c
Compare
fmeum
force-pushed
the
drop-cc-runfiles-library
branch
from
7f99822 to
0623369
Compare
|
@comius CI is green |
comius
approved these changes
Nov 21, 2024
|
I suspect some problems during import, so let me import this myself. |
github-actions
bot
removed
the
awaiting-review
|
@iancha1992 Could you mark this for 8.1.0? |
|
@bazel-io fork 8.0.0 |
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Dec 13, 2024
This requires adding `@rules_cc//cc/runfiles` to the list of targets that `BAZEL_REPOSITORY_NAME` is defined for. Closes bazelbuild#24393. PiperOrigin-RevId: 699127359 Change-Id: Iff0b961ec5ff27daf8e96e49acc5d57a1b9c4274 (cherry picked from commit 8a5e70c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires adding
@rules_cc//cc/runfilesto the list of targets thatBAZEL_REPOSITORY_NAMEis defined for.