Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note to coverage documentation about GCOV_PREFIX_STRIP on MacOS. #24382

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a note to coverage documentation about GCOV_PREFIX_STRIP on MacOS. #24382

wants to merge 1 commit into from

Conversation

c-mita
Copy link
Member

@c-mita c-mita commented Nov 19, 2024

No description provided.

@c-mita c-mita added coverage team-Rules-CPP Issues for C++ rules labels Nov 19, 2024
@github-actions github-actions bot added team-Documentation Documentation improvements that cannot be directly linked to other team labels awaiting-review PR is awaiting review from an assigned reviewer labels Nov 19, 2024
@c-mita c-mita mentioned this pull request Nov 19, 2024
Open
pzembrod
pzembrod approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@pzembrod pzembrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should figure out in a follow up what guidance we can give to find out the correct - or a working - value for GCOV_PREFIX_STRIP, but as it is it is already an improvement; see issue #23719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzembrod pzembrod pzembrod approved these changes

@ulfjack ulfjack Awaiting requested review from ulfjack

@gregestren gregestren Awaiting requested review from gregestren gregestren is a code owner

@fweikert fweikert Awaiting requested review from fweikert fweikert is a code owner

Assignees
No one assigned
Labels
awaiting-review PR is awaiting review from an assigned reviewer coverage team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Rules-CPP Issues for C++ rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-mita @pzembrod