[8.0.0] Parse Starlark files as raw bytes for Bzlmod #24362
Merged
+80
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As long as Bazel internally represents strings as raw bytes "encoded" in Latin-1, the same must be true for all Starlark files that may contain file system paths. Also includes changes to the Python test setup: * `ScratchFile` now always writes files as UTF-8 * `RunProgram` encodes and decodes stdin/stderr/stdout as UTF-8 * `download` no longer leaks a file Closes bazelbuild#24217. PiperOrigin-RevId: 697550082 Change-Id: If7f3fc7ddace2cda5e1f8e48a65406aa54f2a6d8
bazel-io
added
team-ExternalDeps
meteorcloudy
approved these changes
Nov 18, 2024
Merged
via the queue into
bazelbuild:release-8.0.0
with commit Nov 18, 2024
eb0c276
46 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As long as Bazel internally represents strings as raw bytes "encoded" in Latin-1, the same must be true for all Starlark files that may contain file system paths.
Also includes changes to the Python test setup:
ScratchFilenow always writes files as UTF-8RunProgramencodes and decodes stdin/stderr/stdout as UTF-8downloadno longer leaks a fileCloses #24217.
PiperOrigin-RevId: 697550082
Change-Id: If7f3fc7ddace2cda5e1f8e48a65406aa54f2a6d8
Commit fba8603