Do not export rlocation from test setup
#24256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rlocation` implementation lacks many of the features of the shell runfiles library, which should be dependend on explicitly instead. When called, `rlocation` will now fail with an error message.
|
@bazel-io fork 8.0.0 |
github-actions
bot
added
the
awaiting-review
meteorcloudy
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Nov 11, 2024
The `rlocation` implementation lacks many of the features of the shell runfiles library, which should be dependend on explicitly instead. When called, `rlocation` will now fail with an error message. Closes bazelbuild#24256. PiperOrigin-RevId: 695241586 Change-Id: I7059c329fd6ca518623d7be8ad3514082097c191
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
The `rlocation` implementation lacks many of the features of the shell runfiles library, which should be dependend on explicitly instead. When called, `rlocation` will now fail with an error message. Closes #24256. PiperOrigin-RevId: 695241586 Change-Id: I7059c329fd6ca518623d7be8ad3514082097c191 Commit 1312007 Co-authored-by: Fabian Meumertzheim <[email protected]>
| @@ -236,6 +234,15 @@ else | |||
| TEST_PATH="$(rlocation $TEST_WORKSPACE/$EXE)" | |||
| fi | |||
|
|
|||
| # Redefine rlocation to notify users of its removal - it used to be exported. | |||
| # TODO: Remove this before Bazel 9. | |||
| function rlocation() { | |||
There was a problem hiding this comment.
This doesn't seem to be compatible with /bin/sh which caused a test failure at https://buildkite.com/bazel/google-bazel-presubmit/builds/87576#0193afe3-eb2a-49df-b687-13d1be1ce0f7
I can change #!/bin/sh to #!/usr/bin/env bash to fix it in pywrap_template.txt, but maybe we should try to make it compatible?
There was a problem hiding this comment.
function rlocation() {
caller 0 | {
read LINE SUB FILE
echo >&2 "ERROR: rlocation is no longer implicitly provided by Bazel's test setup, but called from $SUB in line $LINE of $FILE. Please use https://github.com/bazelbuild/rules_shell/blob/main/shell/runfiles/runfiles.bash instead."
exit 1
}
}
seems to work
copybara-service bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
Addressing #24256 (comment) PiperOrigin-RevId: 704624513 Change-Id: I73ec6559a7a7b2465abd2faae0e687a97ea77db9
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Dec 10, 2024
Addressing bazelbuild#24256 (comment) PiperOrigin-RevId: 704624513 Change-Id: I73ec6559a7a7b2465abd2faae0e687a97ea77db9
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
Addressing #24256 (comment) PiperOrigin-RevId: 704624513 Change-Id: I73ec6559a7a7b2465abd2faae0e687a97ea77db9 Commit 9ed06ad Co-authored-by: Googler <[email protected]>
copybara-service bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
pywrapper_template.txt change was due to #24256 (comment) PiperOrigin-RevId: 705079774 Change-Id: I4acbce5096b87e30add5cba1632fae1eab7627c0
ramil-bitrise
pushed a commit
to bitrise-io/bazel
that referenced
this pull request
Dec 18, 2024
The `rlocation` implementation lacks many of the features of the shell runfiles library, which should be dependend on explicitly instead. When called, `rlocation` will now fail with an error message. Closes bazelbuild#24256. PiperOrigin-RevId: 695241586 Change-Id: I7059c329fd6ca518623d7be8ad3514082097c191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rlocationimplementation lacks many of the features of the shell runfiles library, which should be dependend on explicitly instead.When called,
rlocationwill now fail with an error message.