Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more Unicode bugs #24182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix more Unicode bugs #24182

wants to merge 1 commit into from
+221 −122

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Nov 4, 2024 •
edited
Loading

  • Use Latin-1 in many native file write rules for consistency with the internal encoding.
  • Use Latin-1 for the resolved repository file and the JSON profile.
  • Fix unused_input_list handling of non-ASCII characters in file names.
  • Flip the legacy_utf8 parameter of repository_ctx.file to False and make it a no-op. With the previous default, any non-ASCII characters would be written out as double encoded UTF-8, which is not a useful choice.
  • Change repository_ctx.template to operate on raw bytes for consistency with repository_ctx.read and to fix substitution with non-ASCII keys/values.
  • Move some usages of UTF_8 closer to their usage site to clarify why they are correct.

@fmeum fmeum force-pushed the 23859-unicode-starlark branch 5 times, most recently from d539093 to b378d1f Compare November 5, 2024 14:29
@fmeum fmeum requested a review from tjgq November 5, 2024 15:55
@fmeum fmeum marked this pull request as ready for review November 5, 2024 15:55
@fmeum fmeum requested review from aranguyen and removed request for a team November 5, 2024 15:55
@github-actions github-actions bot added team-Performance Issues for Performance teams team-Configurability platforms, toolchains, cquery, select(), config transitions team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. team-Rules-Java Issues for Java rules team-Rules-CPP Issues for C++ rules team-Local-Exec Issues and PRs for the Execution (Local) team team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Nov 5, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 5, 2024

@tjgq This is stacked on #24010, but the last commit is new and ready for review.

@tjgq
Copy link
Contributor

tjgq commented Nov 7, 2024

@fmeum Mind rebasing before I review?

@fmeum
Copy link
Collaborator Author

fmeum commented Nov 7, 2024

@tjgq Rebased! Let me know if you would prefer me to split this up further to simplify the review.

@fmeum
Copy link
Collaborator Author

fmeum commented Nov 7, 2024

@bazel-io fork 8.0.0

@bazel-io bazel-io mentioned this pull request Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjgq tjgq Awaiting requested review from tjgq

Assignees
No one assigned
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Configurability platforms, toolchains, cquery, select(), config transitions team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. team-Local-Exec Issues and PRs for the Execution (Local) team team-Performance Issues for Performance teams team-Remote-Exec Issues and PRs for the Execution (Remote) team team-Rules-CPP Issues for C++ rules team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmeum @tjgq