Fix more Unicode bugs #24182
Closed
Fix more Unicode bugs #24182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
23859-unicode-starlark
branch
5 times, most recently
from
d539093 to
b378d1f
Compare
fmeum
requested review from
a team,
lberki,
Wyverald and
meteorcloudy
as code owners
fmeum
force-pushed
the
23859-unicode-starlark
branch
from
b378d1f to
db728d4
Compare
github-actions
bot
added
team-Performance
fmeum
removed request for
a team,
lberki,
Wyverald,
meteorcloudy and
aranguyen
|
@fmeum Mind rebasing before I review? |
fmeum
force-pushed
the
23859-unicode-starlark
branch
from
c2226bd to
8670006
Compare
|
@tjgq Rebased onto master. |
tjgq
approved these changes
Nov 15, 2024
tjgq
added
awaiting-PR-merge
|
@bazel-io fork 8.0.0 |
|
@fmeum can you please resolve the conflicts? Thanks! |
fmeum
force-pushed
the
23859-unicode-starlark
branch
from
8670006 to
664f29c
Compare
|
@iancha1992 Rebased |
github-actions
bot
removed
the
awaiting-PR-merge
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Nov 19, 2024
* Use Latin-1 in many native file write rules for consistency with the internal encoding. * Use Latin-1 for the resolved repository file and the JSON profile. * Fix `unused_input_list` handling of non-ASCII characters in file names. * Flip the `legacy_utf8` parameter of `repository_ctx.file` to `False` and make it a no-op. With the previous default, any non-ASCII characters would be written out as double encoded UTF-8, which is not a useful choice. * Change `repository_ctx.template` to operate on raw bytes for consistency with `repository_ctx.read` and to fix substitution with non-ASCII keys/values. * Move some usages of `UTF_8` closer to their usage site to clarify why they are correct. * Fixes parsing of dependency files with Unicode character contents (`/showIncludes` and `.d` files) Closes bazelbuild#24182. PiperOrigin-RevId: 698111811 Change-Id: Ie43bab9eb5963bf81690dd8985d358f544a711c9 (cherry picked from commit 3fdec93)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
* Use Latin-1 in many native file write rules for consistency with the internal encoding. * Use Latin-1 for the resolved repository file and the JSON profile. * Fix `unused_input_list` handling of non-ASCII characters in file names. * Flip the `legacy_utf8` parameter of `repository_ctx.file` to `False` and make it a no-op. With the previous default, any non-ASCII characters would be written out as double encoded UTF-8, which is not a useful choice. * Change `repository_ctx.template` to operate on raw bytes for consistency with `repository_ctx.read` and to fix substitution with non-ASCII keys/values. * Move some usages of `UTF_8` closer to their usage site to clarify why they are correct. * Fixes parsing of dependency files with Unicode character contents (`/showIncludes` and `.d` files) Closes #24182. PiperOrigin-RevId: 698111811 Change-Id: Ie43bab9eb5963bf81690dd8985d358f544a711c9 (cherry picked from commit 3fdec93) Fixes #24242
|
The changes in this PR have been included in Bazel 8.0.0 RC3. Please test out the release candidate and report any issues as soon as possible. |
|
@tjgq has a better understanding of the cause than I do (I just noticed the failures and initiated the rollback). |
|
See b/381060195 for some details. I'm fairly confident that the root cause was in Google code, not Bazel code, and I expect the fix to be very localized. So, absent evidence that it breaks anything externally, I'd recommend sticking with the cherry-pick for now. |
ramil-bitrise
pushed a commit
to bitrise-io/bazel
that referenced
this pull request
Dec 18, 2024
* Use Latin-1 in many native file write rules for consistency with the internal encoding. * Use Latin-1 for the resolved repository file and the JSON profile. * Fix `unused_input_list` handling of non-ASCII characters in file names. * Flip the `legacy_utf8` parameter of `repository_ctx.file` to `False` and make it a no-op. With the previous default, any non-ASCII characters would be written out as double encoded UTF-8, which is not a useful choice. * Change `repository_ctx.template` to operate on raw bytes for consistency with `repository_ctx.read` and to fix substitution with non-ASCII keys/values. * Move some usages of `UTF_8` closer to their usage site to clarify why they are correct. * Fixes parsing of dependency files with Unicode character contents (`/showIncludes` and `.d` files) Closes bazelbuild#24182. PiperOrigin-RevId: 698111811 Change-Id: Ie43bab9eb5963bf81690dd8985d358f544a711c9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unused_input_listhandling of non-ASCII characters in file names.legacy_utf8parameter ofrepository_ctx.filetoFalseand make it a no-op. With the previous default, any non-ASCII characters would be written out as double encoded UTF-8, which is not a useful choice.repository_ctx.templateto operate on raw bytes for consistency withrepository_ctx.readand to fix substitution with non-ASCII keys/values.UTF_8closer to their usage site to clarify why they are correct./showIncludesand.dfiles)