Acknowledge TASTY as known ClassFile attribute in ijar
#24165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
iancha1992
added
the
team-Rules-Server
fmeum
added
team-Rules-Java
cushon
approved these changes
Oct 31, 2024
|
@cushon Is this missing the awaiting-merge label or are you working on the import? |
cushon
added
the
awaiting-PR-merge
github-actions
bot
removed
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently producing
ijarusing Scala 3 produces the following warnings:TASTY is a Scala 3 specific ClassFile attribute and informs that for given
.classfile there is also emmited as.tastyfile (these were handled in #12529). It can be consumed in the same way as currently handledScalaandScalaSigattributes.Handling that should remove redundant warnings
Here's example on how this attribute is emmited:
https://github.com/scala/scala3/blob/91ef92159c628eaeab8311dc82bed7ed4fe03c63/compiler/src/dotty/tools/backend/jvm/CodeGen.scala#L92-L110