Add repository_ctx.rename() for renaming files or directories
#24020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-ExternalDeps
fmeum
reviewed
Oct 17, 2024
.../java/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkRepositoryContext.java
Outdated
Show resolved
Hide resolved
.../java/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkRepositoryContext.java
Show resolved
Hide resolved
.../java/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkRepositoryContext.java
Show resolved
Hide resolved
jmillikin
force-pushed
the
repository-ctx-rename
branch
from
3dacc59
to
22fe850
Compare
This allows the directory structure of third-party archives to be rearranged without platform-specific commands, and without requiring symlink support from the platform.
jmillikin
force-pushed
the
repository-ctx-rename
branch
from
22fe850
to
800afdc
Compare
fmeum
approved these changes
Oct 17, 2024
.../java/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkRepositoryContext.java
Show resolved
Hide resolved
meteorcloudy
requested changes
Oct 18, 2024
.../java/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkRepositoryContext.java
Show resolved
Hide resolved
meteorcloudy
added
awaiting-PR-merge
Wyverald
reviewed
Oct 22, 2024
.../java/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkRepositoryContext.java
Show resolved
Hide resolved
|
Gentle ping? |
|
@Wyverald Any additional concerns? |
github-actions
bot
removed
the
awaiting-PR-merge
|
@bazel-io fork 8.0.0 |
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Nov 7, 2024
This allows the directory structure of third-party archives to be rearranged without platform-specific commands, and without requiring symlink support from the platform. Closes bazelbuild#24020. PiperOrigin-RevId: 694246834 Change-Id: I4831d610c5fb841640af1b1b864172ee38319a6b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the directory structure of third-party archives to be rearranged without platform-specific commands, and without requiring symlink support from the platform.