Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix most Unicode encoding bugs #24010

Closed
wants to merge 19 commits into from
Closed

Fix most Unicode encoding bugs #24010

wants to merge 19 commits into from
+1,434 −812

Commits on Oct 31, 2024

  1. Make more parts of the client's Windows implementation Unicode-aware 

    This also fixes the behavior of SetEnv on Windows, which previously would remove an environment variable if passed an empty value for it, which doesn't match the Unix behavior.
    @fmeum
    fmeum committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    c7dac06 View commit details
    Browse the repository at this point in the history

  2. Make MacOSXFsEventsDiffAwareness UTF-8 aware 

    It previously used the `GetStringUTF` JNI method, which, despite its name, doesn't return the UTF-8 representation of a string, but modified CESU-8 (nobody ever wants this).
    @fmeum
    fmeum committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d1aa969 View commit details
    Browse the repository at this point in the history

  3. Read the downloader config using Bazel's FileSystem

    @fmeum
    fmeum committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a486281 View commit details
    Browse the repository at this point in the history

  4. Consistently reencode strings in FileSystem implementations

    @fmeum
    fmeum committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    c88d102 View commit details
    Browse the repository at this point in the history

  5. Remaining changes

    @fmeum
    fmeum committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    f3a1414 View commit details
    Browse the repository at this point in the history

  6. Address comments on client code

    @fmeum
    fmeum committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b6310c9 View commit details
    Browse the repository at this point in the history

  7. Address comments in string classes

    @fmeum
    fmeum committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    abea30a View commit details
    Browse the repository at this point in the history

  8. Address comments on string encoding

    @fmeum
    fmeum committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    7a4b6a2 View commit details
    Browse the repository at this point in the history

  9. Address comments in FS code

    @fmeum
    fmeum committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    930c2d8 View commit details
    Browse the repository at this point in the history

  10. Address lberki's comments

    @fmeum
    fmeum committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    00f7a39 View commit details
    Browse the repository at this point in the history

  11. Fix IsValidEnvName

    @fmeum
    fmeum committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    f643631 View commit details
    Browse the repository at this point in the history

  12. Set up locale for watchfs_test

    @fmeum
    fmeum committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    013e860 View commit details
    Browse the repository at this point in the history

  13. Longer wait

    @fmeum
    fmeum committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a3a7647 View commit details
    Browse the repository at this point in the history

  14. Mark watchfs_test as exclusive

    @fmeum
    fmeum committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    9f0e549 View commit details
    Browse the repository at this point in the history

  15. Address comments

    @fmeum
    fmeum committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    c7992ca View commit details
    Browse the repository at this point in the history

  16. Fix conflicts

    @fmeum
    fmeum committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ffde435 View commit details
    Browse the repository at this point in the history

  17. Force Latin-1 for tests

    @fmeum
    fmeum committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    3864bb0 View commit details
    Browse the repository at this point in the history

  18. Add missing conversions in tests

    @fmeum
    fmeum committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a1bba5f View commit details
    Browse the repository at this point in the history

  19. Skip tests in RBE

    @fmeum
    fmeum committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    bb450f9 View commit details
    Browse the repository at this point in the history