-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply single_version_override
patches to module files
#23536
Conversation
src/test/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileFunctionTest.java
Show resolved
Hide resolved
5aa422e
to
a620c84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice! using an in-memory file system is clever. I just have some stylistic comments.
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileFunction.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/repository/PatchUtil.java
Show resolved
Hide resolved
56296d8
to
01795e3
Compare
@bazel-io fork 7.4.0 |
@fmeum can you please squash the commits since it has a third party change? Thanks cc: @bazelbuild/triage |
d88ade4
to
c7b3df9
Compare
@iancha1992 I squashed the commits into a single one. |
Partial commit for third_party/*, see #23536. Change-Id: I6328552feb718a88c5c06926f5630ac3f951194f Signed-off-by: Hee Cha <[email protected]>
Partial commit for third_party/*, see #23536. Change-Id: I6328552feb718a88c5c06926f5630ac3f951194f Signed-off-by: Hee Cha <[email protected]>
567cf87
to
3424342
Compare
I fixed the merge conflict. |
3424342
to
43681a8
Compare
43681a8
to
9dc6013
Compare
Work towards bazelbuild#19301 RELNOTES: Patches to the module file in `single_version_override` are now effective as long as the patch file lies in the root module. Closes bazelbuild#23536. PiperOrigin-RevId: 678347809 Change-Id: I6a3c4664e55cff90c8e42795f95d8ef211348ca9
Work towards bazelbuild#19301 RELNOTES: Patches to the module file in `single_version_override` are now effective as long as the patch file lies in the root module. Closes bazelbuild#23536. PiperOrigin-RevId: 678347809 Change-Id: I6a3c4664e55cff90c8e42795f95d8ef211348ca9
Work towards bazelbuild#19301 RELNOTES: Patches to the module file in `single_version_override` are now effective as long as the patch file lies in the root module. Closes bazelbuild#23536. PiperOrigin-RevId: 678347809 Change-Id: I6a3c4664e55cff90c8e42795f95d8ef211348ca9
The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Work towards #19301
RELNOTES: Patches to the module file in
single_version_override
are now effective as long as the patch file lies in the root module.