Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply single_version_override patches to module files #23536

Closed

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Sep 6, 2024

Work towards #19301

RELNOTES: Patches to the module file in single_version_override are now effective as long as the patch file lies in the root module.

@fmeum fmeum marked this pull request as ready for review September 6, 2024 11:21
@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Sep 6, 2024
@fmeum fmeum force-pushed the 19301-registry-override-patches branch from 5aa422e to a620c84 Compare September 6, 2024 14:08
Copy link
Member

@Wyverald Wyverald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! using an in-memory file system is clever. I just have some stylistic comments.

@fmeum fmeum force-pushed the 19301-registry-override-patches branch from 56296d8 to 01795e3 Compare September 11, 2024 12:13
@fmeum fmeum requested a review from Wyverald September 11, 2024 12:14
@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 11, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 11, 2024

@bazel-io fork 7.4.0

@iancha1992
Copy link
Member

iancha1992 commented Sep 17, 2024

@fmeum can you please squash the commits since it has a third party change? Thanks

cc: @bazelbuild/triage

@fmeum fmeum force-pushed the 19301-registry-override-patches branch from d88ade4 to c7b3df9 Compare September 18, 2024 10:38
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 18, 2024

@iancha1992 I squashed the commits into a single one.

copybara-service bot pushed a commit that referenced this pull request Sep 18, 2024
Partial commit for third_party/*, see #23536.

Change-Id: I6328552feb718a88c5c06926f5630ac3f951194f
Signed-off-by: Hee Cha <[email protected]>
iancha1992 pushed a commit that referenced this pull request Sep 20, 2024
Partial commit for third_party/*, see #23536.

Change-Id: I6328552feb718a88c5c06926f5630ac3f951194f
Signed-off-by: Hee Cha <[email protected]>
@fmeum fmeum requested a review from Wyverald September 23, 2024 12:39
@fmeum fmeum force-pushed the 19301-registry-override-patches branch from 567cf87 to 3424342 Compare September 24, 2024 12:06
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 24, 2024

I fixed the merge conflict.

@fmeum fmeum force-pushed the 19301-registry-override-patches branch from 3424342 to 43681a8 Compare September 24, 2024 12:07
@fmeum fmeum force-pushed the 19301-registry-override-patches branch from 43681a8 to 9dc6013 Compare September 24, 2024 13:15
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 24, 2024
@fmeum fmeum deleted the 19301-registry-override-patches branch September 24, 2024 20:11
fmeum added a commit to fmeum/bazel that referenced this pull request Sep 25, 2024
Work towards bazelbuild#19301

RELNOTES: Patches to the module file in `single_version_override` are now effective as long as the patch file lies in the root module.

Closes bazelbuild#23536.

PiperOrigin-RevId: 678347809
Change-Id: I6a3c4664e55cff90c8e42795f95d8ef211348ca9
fmeum added a commit to fmeum/bazel that referenced this pull request Sep 25, 2024
Work towards bazelbuild#19301

RELNOTES: Patches to the module file in `single_version_override` are now effective as long as the patch file lies in the root module.

Closes bazelbuild#23536.

PiperOrigin-RevId: 678347809
Change-Id: I6a3c4664e55cff90c8e42795f95d8ef211348ca9
fmeum added a commit to fmeum/bazel that referenced this pull request Sep 25, 2024
Work towards bazelbuild#19301

RELNOTES: Patches to the module file in `single_version_override` are now effective as long as the patch file lies in the root module.

Closes bazelbuild#23536.

PiperOrigin-RevId: 678347809
Change-Id: I6a3c4664e55cff90c8e42795f95d8ef211348ca9
github-merge-queue bot pushed a commit that referenced this pull request Sep 25, 2024
Work towards #19301

RELNOTES: Patches to the module file in `single_version_override` are
now effective as long as the patch file lies in the root module.

Closes #23536.

PiperOrigin-RevId: 678347809
Change-Id: I6a3c4664e55cff90c8e42795f95d8ef211348ca9

Closes #23605
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=7.4.0rc1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants