Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java_tools v13.8 / rules_java 7.11.0 #23515

Closed
wants to merge 7 commits into from
Closed

Conversation

iancha1992
Copy link
Member

@iancha1992 iancha1992 added team-Rules-Java Issues for Java rules awaiting-review PR is awaiting review from an assigned reviewer labels Sep 5, 2024
@iancha1992 iancha1992 requested a review from hvadehra September 5, 2024 06:52
@iancha1992
Copy link
Member Author

@hvadehra looks like we're getting a couple presubmit errors. Could you please take a look?

cc: @bazelbuild/triage

@hvadehra
Copy link
Member

hvadehra commented Sep 5, 2024

Looks like a repeat of #23237 (comment)

@iancha1992
Copy link
Member Author

Looks like a repeat of #23237 (comment)

Thanks!

@iancha1992
Copy link
Member Author

@hvadehra looks like the presubmits are failing. Could you please take a look? Thanks!

@hvadehra
Copy link
Member

For one, the abseil-cpp version might be problematic. It was deliberated downgraded from this version in 651294b . @meteorcloudy What can we do here? I tried pinning the version with single_version_override but that seems to break distfile tests as well.

Additionally, re: the cpython download failures, I think because of these changes, the lockfile might need to be updated on all platforms.

@hvadehra
Copy link
Member

I downgraded the abseil-cpp version in rules_java and released v7.11.1. Lets use that instead once bazelbuild/bazel-central-registry#2749 is merged.

@meteorcloudy
Copy link
Member

@Wyverald How close are we to upgrading protobuf and abseil-cpp for Bazel itself?

@hvadehra
Copy link
Member

@iancha1992 I've gone ahead and created #23571 which is looking proimising, I guess we can close this.

@hvadehra
Copy link
Member

#23571 was merged, closing as obsolete.

@hvadehra hvadehra closed this Sep 10, 2024
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Sep 10, 2024
@iancha1992
Copy link
Member Author

@bazel-io fork 7.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants