-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update java_tools v13.8 / rules_java 7.11.0 #23515
Conversation
35a56b0
to
738251c
Compare
@hvadehra looks like we're getting a couple presubmit errors. Could you please take a look? cc: @bazelbuild/triage |
Looks like a repeat of #23237 (comment) |
Thanks! |
5772b66
to
0c2221b
Compare
@hvadehra looks like the presubmits are failing. Could you please take a look? Thanks! |
For one, the abseil-cpp version might be problematic. It was deliberated downgraded from this version in 651294b . @meteorcloudy What can we do here? I tried pinning the version with Additionally, re: the cpython download failures, I think because of these changes, the lockfile might need to be updated on all platforms. |
I downgraded the abseil-cpp version in rules_java and released |
@Wyverald How close are we to upgrading protobuf and abseil-cpp for Bazel itself? |
@iancha1992 I've gone ahead and created #23571 which is looking proimising, I guess we can close this. |
#23571 was merged, closing as obsolete. |
@bazel-io fork 7.4.0 |
bazelbuild/java_tools#91