-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.4.0] Fix ml path for Windows clang-cl cc toolchain #23406
Conversation
Assembly files are not valid inputs for `clang-cl.exe`; the MSVC `ml64.exe` must be used instead. Fixes bazelbuild#23128. Closes bazelbuild#23337. PiperOrigin-RevId: 666406544 Change-Id: Ia7a5fc4702f08a5754145ca286c079d1a4f0e204
cb1bc28
@michaelsiegrist Should we revert this change given more users are broken by this? |
Not yet; I think this fixes an actual bug. I can locally verify that That said, if this is causing more problems than it solves and the argument-passing stuff can't be resolved, I can look at backing this out and solving the problem we're experiencing on my end. |
…uild#23406)" This reverts commit cb1bc28.
Assembly files are not valid inputs for
clang-cl.exe
; the MSVCml64.exe
must be used instead.Fixes #23128.
Closes #23337.
PiperOrigin-RevId: 666406544
Change-Id: Ia7a5fc4702f08a5754145ca286c079d1a4f0e204
Commit e5a083d