Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix locations reported in repo rule instantiation errors for extensions #23363

Closed
wants to merge 2 commits into from
Closed

Fix locations reported in repo rule instantiation errors for extensions #23363

wants to merge 2 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Aug 20, 2024 •
edited
Loading

Since Rule logic drops a call stack entry, errors during repo rule instantiation in a module extension weren't reported with a useful Location.

Work towards #19055

@fmeum
Fix locations reported in repo rule instantiation errors for extensions
b6ca5a9 
Since `Rule` logic drops a call stack entry, errors during repo rule instantiation in a module extension weren't reported with a useful `Location`.
@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Aug 20, 2024
meteorcloudy
meteorcloudy approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Aug 20, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Aug 20, 2024

@bazel-io fork 7.4.0

@bazel-io bazel-io mentioned this pull request Aug 20, 2024
Closed
@fmeum
Copy link
Collaborator Author

fmeum commented Aug 20, 2024

@meteorcloudy I fixed a test.

@fmeum fmeum requested a review from meteorcloudy August 20, 2024 14:06
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Aug 20, 2024
@fmeum fmeum deleted the 19055-fix-creation-callstack branch August 20, 2024 20:35
fmeum added a commit to fmeum/bazel that referenced this pull request Aug 22, 2024
@fmeum
Fix locations reported in repo rule instantiation errors for extensions
477d7fe 
Since `Rule` logic drops a call stack entry, errors during repo rule instantiation in a module extension weren't reported with a useful `Location`.

Work towards bazelbuild#19055

Closes bazelbuild#23363.

PiperOrigin-RevId: 665468188
Change-Id: If67b5b6f290ac4e33b5743e9c1c361a93e1217ef
@fmeum fmeum mentioned this pull request Aug 22, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 26, 2024
@fmeum
[7.4.0] Fix locations reported in repo rule instantiation errors for …
2a46c2f 
…extensions (#23390)

Since `Rule` logic drops a call stack entry, errors during repo rule
instantiation in a module extension weren't reported with a useful
`Location`.

Work towards #19055

Closes #23363.

PiperOrigin-RevId: 665468188
Change-Id: If67b5b6f290ac4e33b5743e9c1c361a93e1217ef

Closes #23364
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=7.4.0rc1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Awaiting requested review from Wyverald Wyverald is a code owner

@meteorcloudy meteorcloudy Awaiting requested review from meteorcloudy meteorcloudy is a code owner

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmeum @iancha1992 @meteorcloudy