Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate linkopts of header-only libraries to cc_shared_library #23215

Closed
wants to merge 2 commits into from
Closed

Propagate linkopts of header-only libraries to cc_shared_library #23215

wants to merge 2 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Aug 5, 2024

Fixes #21884
Fixes #23053

@femshima femshima mentioned this pull request Aug 6, 2024
Merged
@fmeum fmeum force-pushed the 23053-linkopt-header-only branch from 148c217 to 853475d Compare August 7, 2024 13:16
@fmeum fmeum requested a review from oquenchil August 7, 2024 13:17
@fmeum
Copy link
Collaborator Author

fmeum commented Aug 7, 2024

@oquenchil The Windows failure may just be a long path issue. Could we try to use less deeply nested test cases? I don't know how that would interfere with the internal directory layout though.

@fmeum
Copy link
Collaborator Author

fmeum commented Aug 26, 2024

@oquenchil Friendly ping

@fmeum
Copy link
Collaborator Author

fmeum commented Sep 11, 2024

@pzembrod Could you take a look if Pedro is unavailable as a reviewer?

@fmeum
Copy link
Collaborator Author

fmeum commented Sep 24, 2024

@oquenchil Friendly ping

@oquenchil
Copy link
Contributor

oquenchil commented Sep 30, 2024 •
edited
Loading

In my opinion shortening cc_shared_library/test_cc_shared_library should be fine. Removing any parent directories would leave the tests in a weird place I think. Not sure if that buys you enough.

@pzembrod Can you advise Fabian on what the layout should be?

@oquenchil oquenchil requested review from pzembrod and removed request for oquenchil September 30, 2024 10:06
@keith keith mentioned this pull request Oct 9, 2024
Closed
@pzembrod
Copy link
Contributor

I think shortening cc_shared_library/test_cc_shared_libraryX to cc_shared_library/testX is a good idea, not just okay. I think the context for the tests is absolutely clear enough from the parent directory cc_shared_library so it doesn't need to be repeated in the test directory.

@fmeum fmeum marked this pull request as ready for review October 10, 2024 11:49
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Oct 10, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Oct 10, 2024

@bazel-io fork 8.0.0

@bazel-io bazel-io mentioned this pull request Oct 10, 2024
Open
@pzembrod pzembrod added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Oct 10, 2024
@iancha1992 iancha1992 added the team-Rules-CPP Issues for C++ rules label Oct 14, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 16, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Oct 16, 2024
@fmeum @bazel-io
Propagate linkopts of header-only libraries to cc_shared_library
3ef9fb3 
Fixes bazelbuild#21884
Fixes bazelbuild#23053

Closes bazelbuild#23215.

PiperOrigin-RevId: 686518093
Change-Id: I1a6699b169fe4291ad0dda3be7e74f38c8e37bf1
@bazel-io bazel-io mentioned this pull request Oct 16, 2024
Open
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Oct 16, 2024
@fmeum @bazel-io
Propagate linkopts of header-only libraries to cc_shared_library
922a290 
Fixes bazelbuild#21884
Fixes bazelbuild#23053

Closes bazelbuild#23215.

PiperOrigin-RevId: 686518093
Change-Id: I1a6699b169fe4291ad0dda3be7e74f38c8e37bf1
@bazel-io bazel-io mentioned this pull request Oct 16, 2024
Open
@fmeum fmeum deleted the 23053-linkopt-header-only branch October 16, 2024 17:33
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Oct 16, 2024
@fmeum @iancha1992
Propagate linkopts of header-only libraries to cc_shared_library
0af1da8 
Fixes bazelbuild#21884
Fixes bazelbuild#23053

Closes bazelbuild#23215.

PiperOrigin-RevId: 686518093
Change-Id: I1a6699b169fe4291ad0dda3be7e74f38c8e37bf1
@iancha1992 iancha1992 mentioned this pull request Oct 16, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 17, 2024
@iancha1992 @fmeum
[7.4.0] Propagate linkopts of header-only libraries to `cc_shared_l…
c118308 
…ibrary` (#24017)

Fixes #21884
Fixes #23053

Closes #23215.

PiperOrigin-RevId: 686518093
Change-Id: I1a6699b169fe4291ad0dda3be7e74f38c8e37bf1

Commit
0fdb36f

Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzembrod pzembrod pzembrod approved these changes

Assignees
No one assigned
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Milestone
No milestone
4 participants
@fmeum @oquenchil @pzembrod @iancha1992