Be more precise about where to read the URL rewriter config from #22770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an [open issue](bazelbuild#22104) where bazel will occasionally fail at start up time because it is unable to parse the downloader config. While I've yet to create a reliable reproduction for this issue, the one time I've triggered this error with a build with additional logging, it seemed to be because the current working directory wasn't the root of the workspace. While I'm not sure this will actually fully resolve the problem (since I don't know what's causing it) being clearer about where the config file is meant to be can only be a Good Thing.
github-actions
bot
added
team-ExternalDeps
Wyverald
reviewed
Jun 17, 2024
src/main/java/com/google/devtools/build/lib/bazel/repository/downloader/UrlRewriter.java
Outdated
Show resolved
Hide resolved
Wyverald
approved these changes
Jun 20, 2024
Wyverald
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 7.2.1 |
|
@bazel-io fork 7.3.0 |
bazel-io
removed
the
potential release blocker
This was referenced Jun 20, 2024
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jun 20, 2024
There is an [open issue](bazelbuild#22104) where bazel will occasionally fail at start up time because it is unable to parse the downloader config. While I've yet to create a reliable reproduction for this issue, the one time I've triggered this error with a build with additional logging, it seemed to be because the current working directory wasn't the root of the workspace. While I'm not sure this will actually fully resolve the problem (since I don't know what's causing it) being clearer about where the config file is meant to be can only be a Good Thing. Addresses bazelbuild#22104 Closes bazelbuild#22770. PiperOrigin-RevId: 645115556 Change-Id: I7e9bea1c55a106cd767ebfd6d557a7c59c47cd66
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jun 20, 2024
There is an [open issue](bazelbuild#22104) where bazel will occasionally fail at start up time because it is unable to parse the downloader config. While I've yet to create a reliable reproduction for this issue, the one time I've triggered this error with a build with additional logging, it seemed to be because the current working directory wasn't the root of the workspace. While I'm not sure this will actually fully resolve the problem (since I don't know what's causing it) being clearer about where the config file is meant to be can only be a Good Thing. Addresses bazelbuild#22104 Closes bazelbuild#22770. PiperOrigin-RevId: 645115556 Change-Id: I7e9bea1c55a106cd767ebfd6d557a7c59c47cd66
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
…rom (#22831) There is an [open issue](#22104) where bazel will occasionally fail at start up time because it is unable to parse the downloader config. While I've yet to create a reliable reproduction for this issue, the one time I've triggered this error with a build with additional logging, it seemed to be because the current working directory wasn't the root of the workspace. While I'm not sure this will actually fully resolve the problem (since I don't know what's causing it) being clearer about where the config file is meant to be can only be a Good Thing. Addresses #22104 Closes #22770. PiperOrigin-RevId: 645115556 Change-Id: I7e9bea1c55a106cd767ebfd6d557a7c59c47cd66 Commit 0e220f0 Co-authored-by: Simon Mavi Stewart <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
…rom (#22832) There is an [open issue](#22104) where bazel will occasionally fail at start up time because it is unable to parse the downloader config. While I've yet to create a reliable reproduction for this issue, the one time I've triggered this error with a build with additional logging, it seemed to be because the current working directory wasn't the root of the workspace. While I'm not sure this will actually fully resolve the problem (since I don't know what's causing it) being clearer about where the config file is meant to be can only be a Good Thing. Addresses #22104 Closes #22770. PiperOrigin-RevId: 645115556 Change-Id: I7e9bea1c55a106cd767ebfd6d557a7c59c47cd66 Commit 0e220f0 Co-authored-by: Simon Mavi Stewart <[email protected]> Co-authored-by: Yun Peng <[email protected]>
|
The changes in this PR have been included in Bazel 7.2.1 RC2. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an open issue where bazel will occasionally fail at start up time because it is unable to parse the downloader config. While I've yet to create a reliable reproduction for this issue, the one time I've triggered this error with a build with additional logging, it seemed to be because the current working directory wasn't the root of the workspace. While I'm not sure this will actually fully resolve the problem (since I don't know what's causing it) being clearer about where the config file is meant to be can only be a Good Thing.
Addresses #22104