Clarify /rules/lib/builtins/repository_ctx description of default working_directory for execute() #22669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-ExternalDeps
meteorcloudy
requested changes
Jun 10, 2024
| @@ -1561,7 +1561,8 @@ private static String profileArgsDesc(String method, List<String> args) { | |||
| named = true, | |||
| doc = | |||
| "Working directory for command execution.\n" | |||
| + "Can be relative to the repository root or absolute."), | |||
| + "Can be relative to the repository root or absolute.\n" | |||
| + "The default is relative to the repository root."), | |||
There was a problem hiding this comment.
Maybe just "The default is the repository root."?
…king_directory for execute() Fixes bazelbuild#21897 per feedback from @meteorcloudy.
meteorcloudy
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
fmeum
pushed a commit
to fmeum/bazel
that referenced
this pull request
Aug 22, 2024
…king_directory for execute() Fixes bazelbuild#21897 per feedback from @meteorcloudy. Closes bazelbuild#22669. PiperOrigin-RevId: 642185332 Change-Id: I188efa9bf0567d14fdd1b67583f51bebd65af295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21897 per feedback from @meteorcloudy.