Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce file name format for MODULE.bazel includes #22075

Closed
wants to merge 1 commit into from

Conversation

Wyverald
Copy link
Member

They must end in .MODULE.bazel.

Follow-up for #17880

They must end in `.MODULE.bazel`.

Follow-up for #17880
@Wyverald Wyverald requested a review from fmeum April 22, 2024 15:36
@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Apr 22, 2024
@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Apr 22, 2024
fmeum added a commit to fmeum/buildtools that referenced this pull request Apr 22, 2024
After bazelbuild/bazel#22075, these are the
files that can be `include()`ed into `MODULE.bazel` files and should be
formatted and edited just like them.
fmeum added a commit to fmeum/buildtools that referenced this pull request Apr 22, 2024
After bazelbuild/bazel#22075, these are the
files that can be `include()`ed into `MODULE.bazel` files and should be
formatted and edited just like them.
Wyverald pushed a commit to bazelbuild/buildtools that referenced this pull request Apr 22, 2024
After bazelbuild/bazel#22075, these are the
files that can be `include()`ed into `MODULE.bazel` files and should be
formatted and edited just like them.
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Apr 26, 2024
Wyverald added a commit that referenced this pull request Apr 30, 2024
They must end in `.MODULE.bazel`.

Follow-up for #17880

Closes #22075.

PiperOrigin-RevId: 627136756
Change-Id: If9b1797f2e7ddc1aebd929646329e832288bfd8a
@Wyverald Wyverald deleted the wyv-include-format branch May 1, 2024 17:58
apattidb pushed a commit to databricks/buildtools that referenced this pull request May 10, 2024
After bazelbuild/bazel#22075, these are the
files that can be `include()`ed into `MODULE.bazel` files and should be
formatted and edited just like them.
Kila2 pushed a commit to Kila2/bazel that referenced this pull request May 13, 2024
They must end in `.MODULE.bazel`.

Follow-up for bazelbuild#17880

Closes bazelbuild#22075.

PiperOrigin-RevId: 627136756
Change-Id: If9b1797f2e7ddc1aebd929646329e832288bfd8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants