RepositoryCache: add blake3 key type #21998
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-ExternalDeps
sluongng
force-pushed
the
sluongng/repo-cache-blake3
branch
3 times, most recently
from
2d547d0 to
67ff8d7
Compare
fmeum
reviewed
Apr 15, 2024
src/main/java/com/google/devtools/build/lib/bazel/repository/cache/RepositoryCache.java
Outdated
Show resolved
Hide resolved
sgowroji
added
awaiting-user-response
|
@sluongng Could you please take a look at the failing checks? |
sluongng
force-pushed
the
sluongng/repo-cache-blake3
branch
3 times, most recently
from
d68c18b to
71e695e
Compare
|
@sgowroji I think there has been some flakiness in the Bazel CI setup. I have checked the old failures as well as the most recent ones and I don't think they are related to my change. |
fmeum
reviewed
Apr 16, 2024
src/main/java/com/google/devtools/build/lib/vfs/bazel/Blake3HashFunction.java
Outdated
Show resolved
Hide resolved
sgowroji
added
awaiting-review
sluongng
force-pushed
the
sluongng/repo-cache-blake3
branch
from
71e695e to
3a2340a
Compare
Support storing repository cache with blake3 hash function.
sluongng
force-pushed
the
sluongng/repo-cache-blake3
branch
from
3a2340a to
1208d34
Compare
fmeum
approved these changes
Apr 16, 2024
|
@meteorcloudy Could you review this? |
meteorcloudy
approved these changes
Apr 16, 2024
meteorcloudy
added
awaiting-PR-merge
|
@bazel-io fork 7.2.0 |
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Apr 17, 2024
Support storing repository cache with blake3 hash function. Closes bazelbuild#21998. PiperOrigin-RevId: 625727463 Change-Id: I2198adac617c5d6301e56694fe416f3130c61033
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
Support storing repository cache with blake3 hash function. Closes #21998. PiperOrigin-RevId: 625727463 Change-Id: I2198adac617c5d6301e56694fe416f3130c61033 Commit dc5ec2b Co-authored-by: Son Luong Ngoc <[email protected]>
sgowroji
removed
the
awaiting-PR-merge
Kila2
pushed a commit
to Kila2/bazel
that referenced
this pull request
May 13, 2024
Support storing repository cache with blake3 hash function. Closes bazelbuild#21998. PiperOrigin-RevId: 625727463 Change-Id: I2198adac617c5d6301e56694fe416f3130c61033
|
The changes in this PR have been included in Bazel 7.2.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support storing repository cache with blake3 hash function.