Add Oracle JDK 7/8 as optional dependencies. #2137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, `oracle-java7-installer` and `oracle-java8-installer` become alternatives to satisfy the JDK dependency and thus can be implicitly installed when someone just asks to install Bazel by itself. Resolves issue bazelbuild#1821.
|
Can one of the admins verify this patch? |
|
LGTM, thanks! |
|
Reverting the PR as this will be submitted via another mechanism. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change,
oracle-java7-installerandoracle-java8-installerbecomealternatives to satisfy the JDK dependency and thus can be implicitly installed
when someone just asks to install Bazel by itself.
Resolves issue #1821.