[credentialhelper] Respect expires field from helper
#21249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was recently specified in EngFlow/credential-helper-spec#2. RELNOTES[NEW]: Bazel now repects `expires` from Credential Helpers.
github-actions
bot
added
team-Remote-Exec
|
@tjgq PTAL |
tjgq
requested changes
Feb 9, 2024
src/main/java/com/google/devtools/build/lib/authandtls/credentialhelper/CredentialModule.java
Show resolved
Hide resolved
|
@bazel-io fork 7.1.0 |
tjgq
added
awaiting-user-response
|
PTAL |
tjgq
reviewed
Feb 15, 2024
src/main/java/com/google/devtools/build/lib/authandtls/AuthAndTLSOptions.java
Outdated
Show resolved
Hide resolved
tjgq
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Feb 19, 2024
This was recently specified in EngFlow/credential-helper-spec#2. RELNOTES[NEW]: Bazel now respects `expires` from Credential Helpers. Closes bazelbuild#21249. PiperOrigin-RevId: 608208538 Change-Id: Id168f654093c7491a40364e3988af66ad1767443
tjgq
pushed a commit
to tjgq/bazel
that referenced
this pull request
Feb 20, 2024
This was recently specified in EngFlow/credential-helper-spec#2. RELNOTES[NEW]: Bazel now respects `expires` from Credential Helpers. Closes bazelbuild#21249. PiperOrigin-RevId: 608208538 Change-Id: Id168f654093c7491a40364e3988af66ad1767443
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
This was recently specified in EngFlow/credential-helper-spec#2. RELNOTES[NEW]: Bazel now respects `expires` from Credential Helpers. Closes #21249. PiperOrigin-RevId: 608208538 Change-Id: Id168f654093c7491a40364e3988af66ad1767443 Co-authored-by: Yannic Bonenberger <[email protected]>
|
The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was recently specified in EngFlow/credential-helper-spec#2.
RELNOTES[NEW]: Bazel now respects
expiresfrom Credential Helpers.