Also report cycles involving WORKSPACE from BzlmodRepoCycleReporter #20958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
fmeum
force-pushed
the
better-bzlmod-cycle
branch
from
447a677 to
fc36c87
Compare
iancha1992
added
the
team-ExternalDeps
Wyverald
added
awaiting-PR-merge
|
@bazel-io fork 7.1.0 |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 24, 2024
Work towards bazelbuild#20942 On the referenced bug, this prints: ``` ERROR: Circular definition of repositories generated by module extensions and/or .bzl files: .-> repository mapping of @@ | WORKSPACE file | //python:pip.bzl | //python/pip_install:requirements.bzl | //python:defs.bzl | //python:py_import.bzl | //python:py_info.bzl | @@_main~internal_deps~rules_python_internal//:rules_python_config.bzl | @@_main~internal_deps~rules_python_internal | extension 'internal_deps' defined in //python/private/bzlmod:internal_deps.bzl `-- repository mapping of @@ ERROR: Error computing the main repository mapping: cycles detected during computation of main repo mapping ``` Closes bazelbuild#20958. PiperOrigin-RevId: 601183514 Change-Id: If321005b1f6918117d0f5b5763ae2bda4d8e34f1
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
…porter (#21013) Work towards #20942 On the referenced bug, this prints: ``` ERROR: Circular definition of repositories generated by module extensions and/or .bzl files: .-> repository mapping of @@ | WORKSPACE file | //python:pip.bzl | //python/pip_install:requirements.bzl | //python:defs.bzl | //python:py_import.bzl | //python:py_info.bzl | @@_main~internal_deps~rules_python_internal//:rules_python_config.bzl | @@_main~internal_deps~rules_python_internal | extension 'internal_deps' defined in //python/private/bzlmod:internal_deps.bzl `-- repository mapping of @@ ERROR: Error computing the main repository mapping: cycles detected during computation of main repo mapping ``` Closes #20958. Commit fab6414 PiperOrigin-RevId: 601183514 Change-Id: If321005b1f6918117d0f5b5763ae2bda4d8e34f1 Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #20942
On the referenced bug, this prints: